Re: [PATCH] ARM: dts nuvoton: Add EDAC node

[Andrew Jeffery]

Hi William,

As a bit of a nit, you missed the `:` after `dts` in the patch subject.

On Mon, 2024-09-30 at 14:46 -0700, William A. Kennington III wrote:
> From: "William A. Kennington III" <wak@xxxxxxxxxx>
> 
> We have the driver support code, now we just need to expose the device
> node which can export the EDAC properties for the system memory
> controller. Tested on real hardware to verify that error counters show
> up.
> 
> Signed-off-by: William A. Kennington III <wak@xxxxxxxxxx>
> ---
>  arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> index 5aeb5009a5d7..019abceb16a0 100644
> --- a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> +++ b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> @@ -127,6 +127,13 @@ clk: clock-controller@f0801000 {
>  			clocks = <&clk_refclk>, <&clk_sysbypck>, <&clk_mcbypck>;
>  		};
>  
> +		mc: memory-controller@f0824000 {
> +			compatible = "nuvoton,";

This compatible string doesn't look right to me. Are you sure?

Andrew