RE: [net-next v2 0/2] ena: Link IRQs, queues, and NAPI instances

From: Arinzon, David
Date: Wed Oct 02 2024 - 02:29:13 EST



> Greetings:
>
> Welcome to v2. This includes only cosmetic changes, see changelog below
> and in each patch.
>
> This series uses the netdev-genl API to link IRQs and queues to NAPI IDs so
> that this information is queryable by user apps. This is particularly useful for
> epoll-based busy polling apps which rely on having access to the NAPI ID.
>
> I've tested these commits on an EC2 instance with an ENA NIC configured
> and have included test output in the commit messages for each patch
> showing how to query the information.
>
> I noted in the implementation that the driver requests an IRQ for
> management purposes which does not have an associated NAPI. I tried to
> take this into account in patch 1, but would appreciate if ENA maintainers can
> verify I did this correctly.
>
> Thanks,
> Joe
>
> v2:
> - Preserve reverse christmas tree ordering in patch 1
> - Add comment that the API is for non-XDP queues only to patch 2
>
> v1:
> - https://lore.kernel.org/all/20240930195617.37369-1-jdamato@xxxxxxxxxx/
>
> Joe Damato (2):
> ena: Link IRQs to NAPI instances
> ena: Link queues to NAPIs
>
> drivers/net/ethernet/amazon/ena/ena_netdev.c | 40
> +++++++++++++++++---
> 1 file changed, 35 insertions(+), 5 deletions(-)
>
> --
> 2.25.1

Thanks!

Reviewed-by: David Arinzon <darinzon@xxxxxxxxxx>