On Tue, Oct 01, 2024 at 04:57:18PM +0200, Przemek Kitszel wrote:
...
NAKed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
And still NAKed.
Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx>
---
Andy believes that this change is completely wrong C, the reasons
(that I disagree with of course, are in v1, below the commit message).
Have you retested the macro expansion for this version?
...
*/
+
Too many blank lines.
+#define DEFINE_CLASS_IS_CONDITIONAL(_name, _is_cond) \
+static __maybe_unused const bool class_##_name##_is_conditional = _is_cond
...
+ DEFINE_CLASS_IS_CONDITIONAL(_name, 0); \
Here and everywhere else, boolean has values true and false.