Re: [PATCH] drm/i915: Rename functions in the docs to match code changes
From: Andi Shyti
Date: Wed Oct 02 2024 - 07:46:11 EST
Hi Harshit,
On Mon, Sep 30, 2024 at 11:25:54PM -0700, Harshit Mogalapalli wrote:
> make htmldocs is reporting:
>
> drivers/gpu/drm/i915/i915_irq.c:1: warning: 'intel_runtime_pm_disable_interrupts' not found
> drivers/gpu/drm/i915/i915_irq.c:1: warning: 'intel_runtime_pm_enable_interrupts' not found
>
> intel_runtime_pm_disable_interrupts() is renamed to intel_irq_suspend(),
> make documentation changes accordingly.
>
> Fixes: 3de5774cb8c0 ("drm/i915/irq: Rename suspend/resume functions")
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Closes: https://lore.kernel.org/all/20241001134331.7b4d4ca5@xxxxxxxxxxxxxxxx/
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx>
Thanks for your patch. The functions were indeed renamed here(*)
by Rodrigo.
I'm going to remove the "Fixes:" tag as I don't think
documentation fixes are part of it. Unless someone wants it
strongly.
Without the Fixes tag:
Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>
Andi
(*) 3de5774cb8c0 ("drm/i915/irq: Rename suspend/resume functions")
> ---
> Noticed that Stephen also reported this so added a Closes URL.
> ---
> Documentation/gpu/i915.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst
> index ad59ae579237..7a469df675d8 100644
> --- a/Documentation/gpu/i915.rst
> +++ b/Documentation/gpu/i915.rst
> @@ -35,10 +35,10 @@ Interrupt Handling
> :functions: intel_irq_init intel_irq_init_hw intel_hpd_init
>
> .. kernel-doc:: drivers/gpu/drm/i915/i915_irq.c
> - :functions: intel_runtime_pm_disable_interrupts
> + :functions: intel_irq_suspend
>
> .. kernel-doc:: drivers/gpu/drm/i915/i915_irq.c
> - :functions: intel_runtime_pm_enable_interrupts
> + :functions: intel_irq_resume
>
> Intel GVT-g Guest Support(vGPU)
> -------------------------------
> --
> 2.46.0