Re: [PATCH net v2] net: pse-pd: tps23881: Fix boolean evaluation for bitmask checks

From: Jakub Kicinski
Date: Wed Oct 02 2024 - 08:28:30 EST


On Wed, 2 Oct 2024 05:24:31 -0700 Jakub Kicinski wrote:
> On Wed, 2 Oct 2024 12:23:40 +0200 Kory Maincent wrote:
> > In the case of 4-pair PoE, this led to incorrect enabled and
> > delivering status values.
>
> Could you elaborate? The patch looks like a noop I must be missing some
> key aspect..

Reading the discussion on v1 it seems you're doing this to be safe,
because there was a problem with x &= val & MASK; elsewhere.
If that's the case, please resend to net-next and make it clear it's
not a fix.