Re: [PATCH v4 20/39] x86/resctrl: Change mon_event_config_{read,write}() to be arch helpers

[James Morse]

Hi Reinette,

On 14/08/2024 05:02, Reinette Chatre wrote:
> On 8/2/24 10:28 AM, James Morse wrote:
>> @@ -1617,14 +1612,15 @@ static void mon_event_config_read(void *info)
>>       mon_info->mon_config = msrval & MAX_EVT_CONFIG_BITS;
>>   }
>>   -static void mondata_config_read(struct rdt_mon_domain *d, struct mon_config_info
>> *mon_info)
>> +static void mondata_config_read(struct resctrl_mon_config_info *mon_info)
>>   {
>> -    smp_call_function_any(&d->hdr.cpu_mask, mon_event_config_read, mon_info, 1);
>> +    smp_call_function_any(&mon_info->d->hdr.cpu_mask,
>> +                  resctrl_arch_mon_event_config_read, mon_info, 1);
>>   }
>>     static int mbm_config_show(struct seq_file *s, struct rdt_resource *r, u32 evtid)
>>   {
>> -    struct mon_config_info mon_info = {0};
>> +    struct resctrl_mon_config_info mon_info = {0};
>>       struct rdt_mon_domain *dom;
>>       bool sep = false;
>>   
> 
> Patch looks good, just a fyi:
> https://lore.kernel.org/lkml/b2ebc809c8b6c6440d17b12ccf7c2d29aaafd488.1720868538.git.christophe.jaillet@xxxxxxxxxx

Right - I'll pick that as prerequisite so that it rebases out neatly.


Thanks,

James