Re: [PATCH net] net: phy: dp83869: fix memory corruption when enabling fiber

From: Andrew Lunn
Date: Wed Oct 02 2024 - 13:03:27 EST


On Wed, Oct 02, 2024 at 06:18:07PM +0200, Ingo van Lil wrote:
> When configuring the fiber port, the DP83869 PHY driver incorrectly
> calls linkmode_set_bit() with a bit mask (1 << 10) rather than a bit
> number (10). This corrupts some other memory location -- in case of
> arm64 the priv pointer in the same structure.
>
> Since the advertising flags are updated from supported at the end of the
> function the incorrect line isn't needed at all and can be removed.
>
> Fixes: a29de52ba2a1 ("net: dp83869: Add ability to advertise Fiber connection")
> Signed-off-by: Ingo van Lil <inguin@xxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew