Re: [PATCH v1] mm: zswap: Delete comments for "value" member of 'struct zswap_entry'.
From: Nhat Pham
Date: Wed Oct 02 2024 - 14:15:32 EST
On Wed, Oct 2, 2024 at 10:32 AM Kanchana P Sridhar
<kanchana.p.sridhar@xxxxxxxxx> wrote:
>
> Made a minor edit in the comments for 'struct zswap_entry' to delete
> the description of the 'value' member that was deleted in commit
> 20a5532ffa53d6ecf41ded920a7b0ff9c65a7dcf ("mm: remove code to handle
> same filled pages").
Is it worth adding a Fixes tag for this? FWIW, it's really just a
documentation correction, not an actual bug fix. But it's a "fix"
nevertheless...
>
> Signed-off-by: Kanchana P Sridhar <kanchana.p.sridhar@xxxxxxxxx>
> ---
> mm/zswap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/zswap.c b/mm/zswap.c
> index 09aaf70f95c6..c3e257904b36 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -190,7 +190,6 @@ static struct shrinker *zswap_shrinker;
> * section for context.
> * pool - the zswap_pool the entry's data is in
> * handle - zpool allocation handle that stores the compressed page data
> - * value - value of the same-value filled pages which have same content
> * objcg - the obj_cgroup that the compressed memory is charged to
> * lru - handle to the pool's lru used to evict pages.
> */
Thanks Kanchana!
Reviewed-by: Nhat Pham <nphamcs@xxxxxxxxx>