Re: [PATCH net-next v2] net: stmmac: dwmac4: Add ip payload error statistics
From: Serge Semin
Date: Wed Oct 02 2024 - 14:21:18 EST
Hi Minda
On Mon, Sep 30, 2024 at 07:02:05PM GMT, Minda Chen wrote:
Since v3 is going to be required anyway, here are several nitpicks:
> Add dwmac4 ip payload error statistics, and rename discripter bit macro
> because latest version descriptor IPCE bit claims ip checksum error or
> l4 segment length error.
s/dwmac4/DW QoS Eth v4/v5
s/ip/IP
L4-segment is a too broad definition in this case. The doc says about
just three protocols: TCP, UDP, or ICMP, so
s/l4/TCP, UDP, or ICMP
Other than that the change looks good.
Reviewed-by: Serge Semin <fancer.lancer@xxxxxxxxx>
-Serge(y)
>
> Signed-off-by: Minda Chen <minda.chen@xxxxxxxxxxxxxxxx>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c | 2 ++
> drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.h | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
> index e99401bcc1f8..a5fb31eb0192 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
> @@ -118,6 +118,8 @@ static int dwmac4_wrback_get_rx_status(struct stmmac_extra_stats *x,
> x->ipv4_pkt_rcvd++;
> if (rdes1 & RDES1_IPV6_HEADER)
> x->ipv6_pkt_rcvd++;
> + if (rdes1 & RDES1_IP_PAYLOAD_ERROR)
> + x->ip_payload_err++;
>
> if (message_type == RDES_EXT_NO_PTP)
> x->no_ptp_rx_msg_type_ext++;
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.h b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.h
> index 6da070ccd737..1ce6f43d545a 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.h
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.h
> @@ -95,7 +95,7 @@
> #define RDES1_IPV4_HEADER BIT(4)
> #define RDES1_IPV6_HEADER BIT(5)
> #define RDES1_IP_CSUM_BYPASSED BIT(6)
> -#define RDES1_IP_CSUM_ERROR BIT(7)
> +#define RDES1_IP_PAYLOAD_ERROR BIT(7)
> #define RDES1_PTP_MSG_TYPE_MASK GENMASK(11, 8)
> #define RDES1_PTP_PACKET_TYPE BIT(12)
> #define RDES1_PTP_VER BIT(13)
> --
> 2.17.1
>
>