RE: [PATCH v4] docs/gpu: ci: update flake tests requirements

[Deucher, Alexander]

[Public]

> -----Original Message-----
> From: Vignesh Raman <vignesh.raman@xxxxxxxxxxxxx>
> Sent: Tuesday, October 1, 2024 9:51 AM
> To: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Koenig, Christian
> <Christian.Koenig@xxxxxxx>; Pan, Xinhui <Xinhui.Pan@xxxxxxx>; amd-
> gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: daniels@xxxxxxxxxxxxx; helen.koike@xxxxxxxxxxxxx; airlied@xxxxxxxxx;
> daniel@xxxxxxxx; robdclark@xxxxxxxxx; guilherme.gallo@xxxxxxxxxxxxx;
> sergi.blanch.torne@xxxxxxxxxxxxx; deborah.brouwer@xxxxxxxxxxxxx;
> dmitry.baryshkov@xxxxxxxxxx; mripard@xxxxxxxxxx; rodrigo.vivi@xxxxxxxxx;
> quic_abhinavk@xxxxxxxxxxx; linux-mediatek@xxxxxxxxxxxxxxxxxxx; linux-
> amlogic@xxxxxxxxxxxxxxxxxxx; linux-rockchip@xxxxxxxxxxxxxxxxxxx; linux-arm-
> msm@xxxxxxxxxxxxxxx; intel-gfx@xxxxxxxxxxxxxxxxxxxxx; virtualization@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v4] docs/gpu: ci: update flake tests requirements
>
> Hi amdgpu Maintainers,
>
> On 30/09/24 15:22, Vignesh Raman wrote:
> > Update the documentation to specify linking to a relevant GitLab issue
> > or email report for each new flake entry. Added specific GitLab issue
> > urls for amdgpu, i915, msm and xe driver.
> >
> > Acked-by: Maxime Ripard <mripard@xxxxxxxxxx>
> > Acked-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> #intel and xe
> > Acked-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> # msm
> > Acked-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> # msm
> > Signed-off-by: Vignesh Raman <vignesh.raman@xxxxxxxxxxxxx>
> > ---
> >
> > v2:
> > - Add gitlab issue link for msm driver.
> >
> > v3:
> > - Update docs to specify we use email reporting or GitLab issues for flake entries.
> >
> > v4:
> > - Add gitlab issue link for xe driver.
> >
> > ---
> >   Documentation/gpu/automated_testing.rst | 14 ++++++++++----
> >   1 file changed, 10 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/gpu/automated_testing.rst
> > b/Documentation/gpu/automated_testing.rst
> > index 2d5a28866afe..6d7c6086034d 100644
> > --- a/Documentation/gpu/automated_testing.rst
> > +++ b/Documentation/gpu/automated_testing.rst
> > @@ -68,19 +68,25 @@ known to behave unreliably. These tests won't cause a
> job to fail regardless of
> >   the result. They will still be run.
> >
> >   Each new flake entry must be associated with a link to the email
> > reporting the -bug to the author of the affected driver, the board
> > name or Device Tree name of -the board, the first kernel version
> > affected, the IGT version used for tests, -and an approximation of the failure rate.
> > +bug to the author of the affected driver or the relevant GitLab
> > +issue. The entry must also include the board name or Device Tree
> > +name, the first kernel version affected, the IGT version used for tests, and an
> approximation of the failure rate.
> >
> >   They should be provided under the following format::
> >
> > -  # Bug Report: $LORE_OR_PATCHWORK_URL
> > +  # Bug Report: $LORE_URL_OR_GITLAB_ISSUE
> >     # Board Name: broken-board.dtb
> >     # Linux Version: 6.6-rc1
> >     # IGT Version: 1.28-gd2af13d9f
> >     # Failure Rate: 100
> >     flaky-test
> >
> > +Use the appropriate link below to create a GitLab issue:
> > +amdgpu driver: https://gitlab.freedesktop.org/drm/amd/-/issues
>
> Please could you ack this patch. Thanks.

Acked-by: Alex Deucher <alexander.deucher@xxxxxxx>

>
> > +i915 driver: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues
> > +msm driver: https://gitlab.freedesktop.org/drm/msm/-/issues
> > +xe driver: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues
> > +
> >   drivers/gpu/drm/ci/${DRIVER_NAME}-${HW_REVISION}-skips.txt
> >   -----------------------------------------------------------
> >
>
> Regards,
> Vignesh