Re: [v2 PATCH] iommu/arm-smmu-v3: Fix L1 stream table index calculation for 32-bit sid size

From: Yang Shi
Date: Wed Oct 02 2024 - 15:04:48 EST




On 10/2/24 11:17 AM, Nicolin Chen wrote:
I think both v1 and v2 are missing iommu@xxxxxxxxxxxxxxx in CC.

Will do it for the later revision.


On Wed, Oct 02, 2024 at 10:55:14AM -0700, Yang Shi wrote:
+static inline unsigned int arm_smmu_strtab_max_sid(struct arm_smmu_device *smmu)
+{
+ return (1ULL << smmu->sid_bits);
+}
+
Hmm, why ULL gets truncated to unsigned int here?

No particular reason, but it should be better to not truncate here. Will fix it.


Thanks
Nicolin