Re: [PATCH v3] kselftest/devices/probe: Fix SyntaxWarning in regex strings for Python3

From: Shuah Khan
Date: Wed Oct 02 2024 - 16:33:45 EST


On 10/2/24 03:00, Alessandro Zanni wrote:
Hello,

this email is just a friendly reminder to know if the present patch is going to be applied or not.

Thank you.
Best Regards,
Alessandro Zanni


No top posting please.

On 24/08/06 02:14, Alessandro Zanni wrote:
Insert raw strings to prevent Python3 from interpreting string literals
as Unicode strings and "\d" as invalid escaped sequence.

Fix the warnings:

tools/testing/selftests/devices/probe/test_discoverable_devices.py:48:
SyntaxWarning: invalid escape sequence '\d' usb_controller_sysfs_dir =
"usb[\d]+"

tools/testing/selftests/devices/probe/test_discoverable_devices.py: 94:
SyntaxWarning: invalid escape sequence '\d' re_usb_version =
re.compile("PRODUCT=.*/(\d)/.*")

Fixes: dacf1d7a78bf ("kselftest: Add test to verify probe of devices from
discoverable buses")


checkpatch complained about

WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: 160c826b4dd0 ("selftest: hid: add missing run-hid-tools-tests.sh")'
#110:
Fixes: dacf1d7a78bf ("kselftest: Add test to verify probe of devices from
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>
Signed-off-by: Alessandro Zanni <alessandro.zanni87@xxxxxxxxx>

Run checkpatch before sending the patch. I fixed the problem
and applied to linux-kselftest fixes branch for next rc.

Sorry for the delay.

thanks,
-- Shuah