Re: [PATCH net-next v4 06/12] net: vxlan: make vxlan_snoop() return drop reasons

[Menglong Dong]

On Wed, Oct 2, 2024 at 9:35 PM Simon Horman <horms@xxxxxxxxxx> wrote:
>
> On Tue, Oct 01, 2024 at 03:32:19PM +0800, Menglong Dong wrote:
> > Change the return type of vxlan_snoop() from bool to enum
> > skb_drop_reason. In this commit, two drop reasons are introduced:
> >
> >   SKB_DROP_REASON_VXLAN_INVALID_SMAC
> >   SKB_DROP_REASON_VXLAN_ENTRY_EXISTS
> >
> > Signed-off-by: Menglong Dong <dongml2@xxxxxxxxxxxxxxx>
> > ---
> > v4:
> > - rename SKB_DROP_REASON_VXLAN_INVALID_SMAC to
> >   SKB_DROP_REASON_MAC_INVALID_SOURCE
>
> super-nit: SKB_DROP_REASON_VXLAN_INVALID_SMAC was renamed in the code below
>            but not the patch description above
>

Oops, my mistake! What should I do with it? Is it worth
to send a new version?

Thanks!
Menglong Dong

> In any case, this looks good to me.
>
> Reviewed-by: Simon Horman <horms@xxxxxxxxxx>