Re: [PATCH v2] PM: QoS: Export dev_pm_qos_read_value

[Markus Schneider-Pargmann]

On Thu, Oct 03, 2024 at 08:02:04AM GMT, Greg Kroah-Hartman wrote:
> On Wed, Oct 02, 2024 at 09:44:46PM +0200, Markus Schneider-Pargmann wrote:
> > Export the function dev_pm_qos_read_value(). Most other functions
> > mentioned in Documentation/power/pm_qos_interface.rst are already
> > exported, so export this one as well.
> > 
> > This function will be used to read the resume latency in a driver that
> > can also be compiled as a module.
> 
> We don't add exports for no in-kernel users, sorry.  Send this as part
> of a series that requires it.

Sorry if this was unclear, it is for an in-kernel driver (ti_sci.c) that
can be built as a module. When built as a module it can't use this
function if it is not exported.

> 
> > Signed-off-by: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx>
> > Reviewed-by: Dhruva Gole <d-gole@xxxxxx>
> > Reviewed-by: Kevin Hilman <khilman@xxxxxxxxxxxx>
> > Tested-by: Kevin Hilman <khilman@xxxxxxxxxxxx>
> > ---
> > 
> > Notes:
> >     Changes in v2:
> >      - Rephrase the commit message
> >      - Move the patch out of the series
> >        'firmware: ti_sci: Introduce system suspend support'
> 
> Odd, why did you do that?

It was suggested to me off-list that it may be better or easier to send
this separately.

Best
Markus

Attachment: signature.asc
Description: PGP signature