Re: [PATCH v2 2/2] mtd: nand: raw: gpmi: improve power management handling

From: Miquel Raynal
Date: Thu Oct 03 2024 - 03:39:04 EST


Hi Han,

han.xu@xxxxxxx wrote on Wed, 2 Oct 2024 10:39:44 -0500:

> The commit refactors the power management handling in the gpmi nand
> driver. It removes redundant pm_runtime calls in the probe function,
> handles the pad control in suspend and resume, and moves the calls to
> acquire and release DMA channels to the runtime suspend and resume
> functions.

May I know the motivation to acquire and release the DMA channels
during suspend? In general it seems like a different change which I'd
prefer to see in its own commit with a justification. The rest looks
ok otherwise.

Thanks,
Miquèl