Re: [PATCH 1/1] KVM: nVMX: update VPPR on vmlaunch/vmresume

[Markku Ahvenjärvi]

Hi Sean,

> Talking to myself :-)
A good monologue. :)

As you said, PPR is updated constantly with kvm_vcpu_has_events() anyways.

Actually implicit updates, especially in kvm_apic_has_interrupt(), makes it a
bit difficult to follow when these updates take place. It is quite easy to
accidentally make an update in architecturally incorrect place. Could be
useful to make it explicit.

> Assuming it actually fixes your issue, this is what I'm planning on posting.  I
> suspect KVM botches something when the deprivileged host is active, but given
> that the below will allow for additional cleanups, and practically speaking doesn't
> have any downsides, I don't see any reason to withhold the hack-a-fix.  Though
> hopefully we'll someday figure out exactly what's broken.

It fixes the issue. Thanks a lot Sean!

Kind regards,
Markku