Re: [PATCH v3 2/4] media: dt-bindings: Add OmniVision OV08X40

[Bryan O'Donoghue]

On 03/10/2024 11:17, Krzysztof Kozlowski wrote:
> On 03/10/2024 10:38, Bryan O'Donoghue wrote:
> > On 03/10/2024 09:33, Bryan O'Donoghue wrote:
> > > On 03/10/2024 09:29, Krzysztof Kozlowski wrote:
> > > > On Wed, Oct 02, 2024 at 02:58:44PM +0100, Bryan O'Donoghue wrote:
> > > > > +        properties:
> > > > > +          data-lanes:
> > > > > +            oneOf:
> > > > > +              - items:
> > > > > +                  - const: 1
> > > > > +                  - const: 2
> > > > > +              - items:
> > > > > +                  - const: 1
> > > > > +                  - const: 2
> > > > > +                  - const: 3
> > > > > +                  - const: 4
> > > > > +
> > > > > +          link-frequencies: true
> > > >
> > > > Not much changed here and you did not continued discussion about it.
> > > >
> > > > Best regards,
> > > > Krzysztof
> > >
> > > Ah my mistake, I didn't read the bit at the bottom of your email
> >
> > I'll do this
> >
> > Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml
> >
> >             data-lanes:
> >               description:
> >                 This property is for lane reordering between the THP7312
> >                 and the SoC. The sensor supports either two-lane, or
> >                 four-lane operation.
> >                 If this property is omitted four-lane operation is
> >                 assumed. For two-lane operation the property must be
> >                 set to <1 2>.
> >               minItems: 2
> >               maxItems: 4
> >               items:
> >                 maximum: 4
> >
> > This captures what I'm after.
>
> I commented on link-frequencies.
>
> Best regards,
> Krzysztof

Ah I understand you.

You're saying the link-frequencies we have in 
Documentation/devicetree/bindings/media/i2c/* are redundant absent 
hardware specific link frequencies being enumerated.

I'll either enumerate the acceptable set or drop this.

---
bod