Re: [PATCH v6 00/11] media: rkvdec: Add H.264 High 10 and 4:2:2 profile support
From: Diederik de Haas
Date: Thu Oct 03 2024 - 08:24:11 EST
On Mon Sep 9, 2024 at 9:24 PM CEST, Jonas Karlman wrote:
> This series add H.264 High 10 and 4:2:2 profile support to the Rockchip
> Video Decoder driver.
> ...
> Tested on a ROCK Pi 4 (RK3399) and Rock64 (RK3328):
> ...
>
> Link to v1: https://lore.kernel.org/linux-media/20200701215616.30874-1-jonas@xxxxxxxxx/
>
> To fully runtime test this series you may need FFmpeg patches from [1]
> and fluster patches from [2], this series is also available at [3].
I have been using this patch set and earlier version stemming all the
way back to 2023-10-29 and with a patched ffmpeg and mpv ([1] but
earlier versions before that) I have been enjoying HW accelerated
playback on my Rock64 (rk3328) :-)
So for the series, feel free to add my
Tested-by: Diederik de Haas <didi.debian@xxxxxxxxx>
[1] https://github.com/mpv-player/mpv/pull/14690
Cheers,
Diederik
> [1] https://github.com/Kwiboo/FFmpeg/commits/v4l2request-2024-v2-rkvdec/
> [2] https://github.com/Kwiboo/fluster/commits/ffmpeg-v4l2request-rkvdec/
> [3] https://github.com/Kwiboo/linux-rockchip/commits/linuxtv-rkvdec-high-10-v6/
> [4] https://gist.github.com/Kwiboo/f4ac15576b2c72887ae2bc5d58b5c865
> [5] https://gist.github.com/Kwiboo/459a1c8f1dcb56e45dc7a7a29cc28adf
>
> Regards,
> Jonas
>
> Alex Bee (1):
> media: rkvdec: h264: Don't hardcode SPS/PPS parameters
>
> Jonas Karlman (10):
> media: v4l2-common: Add helpers to calculate bytesperline and
> sizeimage
> media: v4l2: Add NV15 and NV20 pixel formats
> media: rkvdec: h264: Use bytesperline and buffer height as virstride
> media: rkvdec: Extract rkvdec_fill_decoded_pixfmt into helper
> media: rkvdec: Move rkvdec_reset_decoded_fmt helper
> media: rkvdec: Extract decoded format enumeration into helper
> media: rkvdec: Add image format concept
> media: rkvdec: Add get_image_fmt ops
> media: rkvdec: h264: Support High 10 and 4:2:2 profiles
> media: rkvdec: Fix enumerate frame sizes
>
> .../media/v4l/pixfmt-yuv-planar.rst | 128 ++++++++++
> drivers/media/v4l2-core/v4l2-common.c | 80 +++---
> drivers/media/v4l2-core/v4l2-ioctl.c | 2 +
> drivers/staging/media/rkvdec/rkvdec-h264.c | 64 +++--
> drivers/staging/media/rkvdec/rkvdec.c | 239 +++++++++++++-----
> drivers/staging/media/rkvdec/rkvdec.h | 18 +-
> include/uapi/linux/videodev2.h | 2 +
> 7 files changed, 410 insertions(+), 123 deletions(-)
Attachment:
signature.asc
Description: PGP signature