Re: [PATCH v3 2/4] media: dt-bindings: Add OmniVision OV08X40

From: Sakari Ailus
Date: Thu Oct 03 2024 - 08:47:26 EST


Hi Bryan,

On Thu, Oct 03, 2024 at 01:40:34PM +0100, Bryan O'Donoghue wrote:
> On 03/10/2024 13:31, Krzysztof Kozlowski wrote:
> > > > Ah I understand you.
> > > >
> > > > You're saying the link-frequencies we have in
> > > > Documentation/devicetree/bindings/media/i2c/* are redundant absent hardware
> > > > specific link frequencies being enumerated.
> > > >
> > > > I'll either enumerate the acceptable set or drop this.
> > > link-frequencies should remain mandatory in bindings, whether there are
> > > hardware specific limits in bindings or not.
> > > <URL:https://hverkuil.home.xs4all.nl/spec/driver-api/camera-
> > > sensor.html#handling-clocks>
> > Yep and my comment was not under required field. Why all this discussion
> > is taken out of context? No wonder everyone interprets it differently.
> >
> > Best regards,
>
> Just so I'm 100% clear.
>
> required:
> link-frequencies
>
> is required but
>
> properties:
> link-frequencies: true
>
> is not, and presumably should be dropped from other yaml descriptions
> upstream.

Seems good to me.

--
Kind regards,

Sakari Ailus