Re: [RFC PATCH 1/3] powerpc/pseries/iommu: Bring back userspace view for single level TCE tables

From: Jason Gunthorpe
Date: Thu Oct 03 2024 - 09:39:40 EST


On Tue, Mar 19, 2024 at 01:36:51PM -0500, Timothy Pearson wrote:
> > On Tue, Mar 12, 2024 at 01:14:20PM -0500, Shivaprasad G Bhat wrote:
> >> The commit 090bad39b237a ("powerpc/powernv: Add indirect levels to
> >> it_userspace") which implemented the tce indirect levels
> >> support for PowerNV ended up removing the single level support
> >> which existed by default(generic tce_iommu_userspace_view_alloc/free()
> >> calls). On pSeries the TCEs are single level, and the allocation
> >> of userspace view is lost with the removal of generic code.
> >
> > :( :(
> >
> > If this has been broken since 2018 and nobody cared till now can we
> > please go in a direction of moving this code to the new iommu APIs
> > instead of doubling down on more of this old stuff that apparently
> > almost nobody cares about ??
>
> Just FYI Raptor is working on porting things over to the new APIs.
> RFC patches should be posted in the next week or two.

There was a discussion about this at LPC a few weeks ago, did any
patches get prepared?

Jason