Re: [PATCH] mm: percpu: fix typo to pcpu_alloc_noprof() description

From: Vlastimil Babka
Date: Thu Oct 03 2024 - 10:49:25 EST


On 9/24/24 17:24, Jeongjun Park wrote:
> In the previous commit, the function name was changed from pcpu_alloc to
> pcpu_alloc_noprof , but the function description was not changed accordingly.
> The function name should be changed to pcpu_alloc_noprof in the description
> as well.
>
> Signed-off-by: Jeongjun Park <aha310510@xxxxxxxxx>

See 51a7bf0238c2 ("scripts/kernel-doc: drop "_noprof" on function prototypes")

So in fact we can't do that now (as the bot reply suggests), even if
pcpu_alloc() doesnt seem to exist - all the hooks wrapping
pcpu_alloc_noprof() are named differently?

> ---
> mm/percpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/percpu.c b/mm/percpu.c
> index 20d91af8c033..7081b0ed59d6 100644
> --- a/mm/percpu.c
> +++ b/mm/percpu.c
> @@ -1726,7 +1726,7 @@ static void pcpu_alloc_tag_free_hook(struct pcpu_chunk *chunk, int off, size_t s
> #endif
>
> /**
> - * pcpu_alloc - the percpu allocator
> + * pcpu_alloc_noprof - the percpu allocator
> * @size: size of area to allocate in bytes
> * @align: alignment of area (max PAGE_SIZE)
> * @reserved: allocate from the reserved chunk if available
> --
>