Re: [PATCH 5/5] regulator: axp20x: add support for the AXP323

[Chen-Yu Tsai]

On Thu, Oct 3, 2024 at 7:15 PM Andre Przywara <andre.przywara@xxxxxxx> wrote:
>
> The X-Powers AXP323 is a very close sibling of the AXP313A. The only
> difference seems to be the ability to dual-phase the first two DC/DC
> converters.
>
> Place the new AXP323 ID next to the existing AXP313A checks, to let
> them share most code.
> The only difference is the poly-phase detection code, which gets
> extended to check the respective bit in a newly used register.
>
> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>

Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx>


> ---
>  drivers/regulator/axp20x-regulator.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
> index 3ba76dbd0fb9..e3cc59b82ea6 100644
> --- a/drivers/regulator/axp20x-regulator.c
> +++ b/drivers/regulator/axp20x-regulator.c
> @@ -1341,6 +1341,7 @@ static int axp20x_set_dcdc_freq(struct platform_device *pdev, u32 dcdcfreq)
>                 step = 150;
>                 break;
>         case AXP313A_ID:
> +       case AXP323_ID:
>         case AXP717_ID:
>         case AXP15060_ID:
>                 /* The DCDC PWM frequency seems to be fixed to 3 MHz. */
> @@ -1527,6 +1528,15 @@ static bool axp20x_is_polyphase_slave(struct axp20x_dev *axp20x, int id)
>                 }
>                 break;
>
> +       case AXP323_ID:
> +               regmap_read(axp20x->regmap, AXP323_DCDC_MODE_CTRL2, &reg);
> +
> +               switch (id) {
> +               case AXP313A_DCDC2:
> +                       return !!(reg & BIT(1));
> +               }
> +               break;
> +
>         default:
>                 return false;
>         }
> @@ -1565,6 +1575,7 @@ static int axp20x_regulator_probe(struct platform_device *pdev)
>                                                   "x-powers,drive-vbus-en");
>                 break;
>         case AXP313A_ID:
> +       case AXP323_ID:
>                 regulators = axp313a_regulators;
>                 nregulators = AXP313A_REG_ID_MAX;
>                 break;
> --
> 2.25.1
>