Re: [RFC net-next 1/1] idpf: Don't hard code napi_struct size
From: Joe Damato
Date: Thu Oct 03 2024 - 11:47:40 EST
On Thu, Oct 03, 2024 at 03:35:54PM +0200, Alexander Lobakin wrote:
[...]
> napi_struct is the only generic struct whichs size is hardcoded in the
> macros (struct dim is already sizeof()ed, as well as cpumask_var_t), so
> I'm fine with the change you proposed in your first RFC -- I mean
>
> libeth_cacheline_set_assert(struct idpf_q_vector, 112,
> - 424 + 2 * sizeof(struct dim),
> + 24 + sizeof(struct napi_struct) +
> + 2 * sizeof(struct dim),
> 8 + sizeof(cpumask_var_t));
So you are saying to drop the other #defines I added in the RFC and
just embed a sizeof? I just want to be clear so that I send a v2
that'll be correct.