Re: [PATCH v2 1/6] Add AutoFDO support for Clang build

From: Nick Desaulniers
Date: Thu Oct 03 2024 - 12:11:57 EST


On Thu, Oct 3, 2024 at 9:03 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> On Thu, Oct 03, 2024 at 08:51:51AM -0700, Nick Desaulniers wrote:
> > On Thu, Oct 3, 2024 at 8:42 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> > >
> > > On Wed, Oct 02, 2024 at 04:34:00PM -0700, Rong Xu wrote:
> > > > +6) Rebuild the kernel using the AutoFDO profile file with the same config as step 1,
> > > > + (Note CONFIG_AUTOFDO_CLANG needs to be enabled):
> > > > +
> > > > + .. code-block:: sh
> > > > +
> > > > + $ make LLVM=1 CLANG_AUTOFDO_PROFILE=<profile_file
> > > > +
> > >
> > >
> > > Can this be done without the endless ... code-block nonsense?
> >
> > Dunno, I think it looks pretty nice once rendered. Makes it
>
> It makes it absolute crap for all of us who 'render' text documents
> using less or vi.

"It hurts when I punch myself in the face."

https://docs.kernel.org/ is where we point people to, and what we
should be optimizing for (IMO). Jonathan, do we have a policy about
using code-block consistently throughout the kernel docs or not?
Otherwise, this complaint smells like "non-technical non-sense" to me.

--
Thanks,
~Nick Desaulniers