Re: [PATCH v7 01/10] Consolidate IO memcpy/memset into iomap_copy.c

From: Richard Henderson
Date: Thu Oct 03 2024 - 12:47:04 EST


On 9/30/24 06:23, Julian Vetter wrote:
+void memset_io(volatile void __iomem *dst, int c, size_t count)
+{
+ uintptr_t qc = (u8)c;

Missed one change to 'long'

+
+ qc |= qc << 8;
+ qc |= qc << 16;
+
+#ifdef CONFIG_64BIT
+ qc |= qc << 32;
+#endif

Could be 'qc *= -1ul / 0xff;'


r~