Re: [PATCH] sched/psi: fix unnecessary KERN_ERR and memory barrier comment

[Pintu Agarwal]

Hi Joe,

On Wed, 2 Oct 2024 at 05:57, Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> On Mon, 2024-09-30 at 19:21 +0530, Pintu Kumar wrote:
> > These warnings were reported by checkpatch.
> > Fix them with minor changes.
> >
> > WARNING: Possible unnecessary KERN_ERR
> > +                       printk_deferred(KERN_ERR "psi: task underflow! cpu=%d t=%d tasks=[%u %u %u %u] clear=%x set=%x\n",
>
> printk_deferred does not have pr_<level>_deferred variants
> so a KERN_<LEVEL> use here is appropriate.
>
Thank you so much for your review.
Okay I will drop this one and only include the other one related to
"memory barrier missing comments".
Will send a v2 patch if you are okay with it.

Thanks,