Re: [PATCH net-next v4 1/2] dt-bindings: net: ethernet-phy: Add timing-role role property for ethernet PHYs

[Andrew Lunn]

On Thu, Oct 03, 2024 at 03:08:09PM +0200, Oleksij Rempel wrote:
> On Thu, Oct 03, 2024 at 02:08:00PM +0200, Andrew Lunn wrote:
> > > > +      - 'force-master': The PHY is forced to operate as a master.
> > > > +      - 'force-slave': The PHY is forced to operate as a slave.
> > > > +      - 'prefer-master': Prefer the PHY to be master but allow negotiation.
> > > > +      - 'prefer-slave': Prefer the PHY to be slave but allow negotiation.
> > > > +
> > > 
> > > I would suggest to use "preferred" instead of "prefer" to be in sync with existing phy library macros.
> > 
> > How does 802.3 name it?
> 
> 802.3 use "Multiport device" for "preferred master" and "single-port device"
> for "preferred slave". We decided to use other wording back in the past
> to avoid confusing and align it with forced master/slave configurations. 

ethtool is preferred, so it would be more consistent with preferred

[Shrug]

	Andrew