Re: [PATCH][next] drm/nouveau: Avoid -Wflex-array-member-not-at-end warning

From: Danilo Krummrich
Date: Thu Oct 03 2024 - 15:09:14 EST


On 10/3/24 8:44 PM, Gustavo A. R. Silva wrote:


On 03/10/24 12:36, Danilo Krummrich wrote:
On 9/13/24 12:23 PM, Danilo Krummrich wrote:
Hi,

On 9/13/24 10:09 AM, Gustavo A. R. Silva wrote:
Hi all,

Friendly ping: who can take this, please? 🙂

Usually, that's me. But I thought you might want to send a v2 based on Kees'
comments?

Do you plan to follow up on this? I'd prefer if we could get rid of the open-
coded "17". So, maybe just go with the define until we have something like
STACK_FLEX_COUNT()?

Do you mean the following define...?>
nv50_hdmi_enable(...)
{
...
#define data_len    17
    DEFINE_RAW_FLEX(struct nvif_outp_infoframe_v0, args, data, data_len);
...rest of function...
#undef data_len
}

Yes, it's not great, but I think it's better than having the length in two
places.


Thanks
--
Gustavo