Re: [PATCH 4/8] iio: frequency: admv4420: add missing select REMAP_SPI in Kconfig

[Javier Carrasco]

On 03/10/2024 18:49, Javier Carrasco wrote:
> This driver makes use of regmap_spi, but does not select the required
> module.
> Add the missing 'select REGMAP_SPI'.
> 
> Fixes: b59c04155901 ("iio: frequency: admv4420.c: Add support for ADMV4420")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
> ---
>  drivers/iio/frequency/Kconfig | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/iio/frequency/Kconfig b/drivers/iio/frequency/Kconfig
> index 89ae09db5ca5..b90e1ac4b342 100644
> --- a/drivers/iio/frequency/Kconfig
> +++ b/drivers/iio/frequency/Kconfig
> @@ -92,14 +92,15 @@ config ADMV1014
>  	  module will be called admv1014.
>  
>  config ADMV4420
> -       tristate "Analog Devices ADMV4420 K Band Downconverter"
> -       depends on SPI
> -       help
> -         Say yes here to build support for Analog Devices K Band
> -         Downconverter with integrated Fractional-N PLL and VCO.
> -
> -         To compile this driver as a module, choose M here: the
> -         module will be called admv4420.
> +	tristate "Analog Devices ADMV4420 K Band Downconverter"
> +	depends on SPI
> +	select REGMAP_SPI
> +	help
> +	  Say yes here to build support for Analog Devices K Band
> +	  Downconverter with integrated Fractional-N PLL and VCO.
> +
> +	  To compile this driver as a module, choose M here: the
> +	  module will be called admv4420.
>  
>  config ADRF6780
>          tristate "Analog Devices ADRF6780 Microwave Upconverter"
> 

Note that I formatted the entry to use tabs instead of spaces, although
I forgot to add it to the commit message.

Best regards,
Javier Carrasco