Re: [PATCHv2 net-next 05/10] net: lantiq_etop: move phy_disconnect to stop

[Aleksander Jan Bajkowski]

Hi Rosen,

On 1.10.2024 20:46, Rosen Penev wrote:
> phy is initialized in start, not in probe. Move to stop instead of
> remove to disconnect it earlier.
>
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> Reviewed-by: Shannon Nelson <shannon.nelson@xxxxxxx>
> ---
>   drivers/net/ethernet/lantiq_etop.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
> index d1fcbfd3e255..9ca8f01585f6 100644
> --- a/drivers/net/ethernet/lantiq_etop.c
> +++ b/drivers/net/ethernet/lantiq_etop.c
> @@ -447,6 +447,7 @@ ltq_etop_stop(struct net_device *dev)
>   
>   	netif_tx_stop_all_queues(dev);
>   	phy_stop(dev->phydev);
> +	phy_disconnect(dev->phydev);


Phy_disconnect() already calls phy_stop(). The second call is redundant.


Regards,
Aleksander