Re: [PATCH v3] lib/math: Add int_log test suite

From: Shuah Khan
Date: Thu Oct 03 2024 - 17:39:20 EST


On 10/3/24 01:00, David Gow wrote:
On Wed, 25 Sept 2024 at 10:56, Bruno Sobreira França
<brunofrancadevsec@xxxxxxxxx> wrote:

This commit introduces KUnit tests for the intlog2 and intlog10
functions, which compute logarithms in base 2 and base 10, respectively.
The tests cover a range of inputs to ensure the correctness of these
functions across common and edge cases.

Signed-off-by: Bruno Sobreira França <brunofrancadevsec@xxxxxxxxx>
---

Thanks, this looks good to me.

Reviewed-by: David Gow <davidgow@xxxxxxxxxx>

Cheers,
-- David

Changes in v3:
- Fix checkpatch issues reintroduced in v2
Changes in v2:
- Fix the overflow warning reported by the kernel test robot
---

Bruno,

This doesn't apply - please rebase on top of linux-kselftest kunit branch
and send me v4.

I tried to apply, but a few too many merge conflicts. Rebase is a safer
option.

thanks,
-- Shuah