Re: [PATCH net] net: ti: icssg-prueth: Fix race condition for VLAN table access
From: Jakub Kicinski
Date: Thu Oct 03 2024 - 20:41:53 EST
On Thu, 3 Oct 2024 16:29:40 +0530 MD Danish Anwar wrote:
> diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.h b/drivers/net/ethernet/ti/icssg/icssg_prueth.h
> index bba6da2e6bd8..9a33e9ed2976 100644
> --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.h
> +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.h
> @@ -296,6 +296,7 @@ struct prueth {
> bool is_switchmode_supported;
> unsigned char switch_id[MAX_PHYS_ITEM_ID_LEN];
> int default_vlan;
> + spinlock_t vtbl_lock; /* Lock for vtbl in shared memory */
This needs to be kdoc, otherwise:
drivers/net/ethernet/ti/icssg/icssg_prueth.h:301: warning: Function parameter or struct member 'vtbl_lock' not described in 'prueth'
--
pw-bot: cr