RE: [PATCH v1 2/2] Bluetooth: btnxpuart: Add GPIO support to power save feature

[Neeraj Sanjay Kale]

Hi Shenwei,

> >
> > The expected behavior is level trigger.
> > The piece of code you are referring to is from power save init, where
> > we are setting the initial value of GPIO as HIGH.
> > However, if the FW is already present and running, with unknown power
> > save state, a GPIO toggle ensures the chip wakes up, and FW and driver are
> in sync.
> >
> 
> If the module is already in a power-save state, waking it up only to
> immediately return it to power-save seems unnecessary. A more efficient
> approach would be to simply set the GPIO to LOW. This action should
> transition the module into a power-save state regardless of its previous
> condition.
> 
Yes, it seems more efficient. Let me make the change and test.
Ps_init() is expected to make the GPIO low to wake up the chip.
Will include the change in v3 patch.

Correction to my previous reply: 
> > The piece of code you are referring to is from power save init, where
> > we are setting the initial value of GPIO as "LOW".

Thanks,
Neeraj