Re: [PATCH 1/3] dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Allow 'input-schmitt-{enable,disable}' and 'drive-open-drain' properties

[Lad, Prabhakar]

Hi Geert,

Thank you for the review.

On Fri, Oct 4, 2024 at 8:54 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Fabrizio,
>
> On Wed, Sep 18, 2024 at 2:09 PM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > On the RZ/V2H(P) SoC we can configure the 'input-schmitt-{enable,disable}'
> > and 'drive-open-drain' of multiplexed pins. Update the binding
> > documentation to include these properties.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
> > @@ -119,6 +119,9 @@ additionalProperties:
> >          bias-disable: true
> >          bias-pull-down: true
> >          bias-pull-up: true
> > +        input-schmitt-enable: true
> > +        input-schmitt-disable: true
> > +        drive-open-drain: true
>
> I think you also need "drive-push-pull", to disable open drain.
>
Agreed, I will add support for it and send a v2.

Cheers,
Prabhakar

> >          renesas,output-impedance:
> >            description:
> >              Output impedance for pins on the RZ/V2H(P) SoC. The value provided by this
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds