Re: [PATCH net-next v2 1/1] Documentation: networking: add Twisted Pair Ethernet diagnostics at OSI Layer 1

[Oleksij Rempel]

Hi Maxime,

On Thu, Oct 03, 2024 at 09:53:21AM +0200, Maxime Chevallier wrote:
...
> > +  - **Wake-on**: Displays whether Wake-on-LAN is enabled (e.g., **Wake-on: d**
> > +    for disabled). Not used for layer 1 diagnostic.
> 
> (sorry for the long scroll down there) This whole section is more of a
> documentation on what ethtool reports rather than a troubleshooting
> guide. I'm all in for getting proper doc for this, but maybe we could
> move this in a dedicated page, that we would cross-link from that guide
> ?

Ack, I was not sure where to put it. I'll try to come up with ethtool
manual patches and drop for now everything no directly related with the
diagnostic.

> > +This list will evolve with future kernel versions, reflecting new features or
> > +refinements. Below are the current suggestions:
> 
> I'm not sure this TODO list has its place in this troubleshooting
> guide. I agree with the points you list, but this looks more like a
> roadmap for PHY stuff to improve. I don't really know where this list
> could go and if it's common to maintain this kind of "TODO list" in the
> kernel doc though. Maybe Andrew has an idea ?

Yea,  may be it will be enough to send it as separate mail for
discussion.

> Thanks for coming-up with such a detailed guide. I also have some "PHY
> bringup 101" ideas on the common errors faced by developers, and this is
> document would be the ideal place to maintain this crucial information.

Good idea. It will be good to have a list or guide on what options are expected
form from PHY driver and how to test them.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |