Re: [PATCH v7 3/8] fs/block: Check for IOCB_DIRECT in generic_atomic_write_valid()

From: Christoph Hellwig
Date: Fri Oct 04 2024 - 08:34:47 EST


On Fri, Oct 04, 2024 at 09:22:49AM +0000, John Garry wrote:
> Currently FMODE_CAN_ATOMIC_WRITE is set if the bdev can atomic write and
> the file is open for direct IO. This does not work if the file is not
> opened for direct IO, yet fcntl(O_DIRECT) is used on the fd later.

This sound like a bug fix for 6.12-rc?

The fix looks good to me:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>