Re: [PATCH] usb: usbtmc: initialize memory written to device

From: Greg KH
Date: Fri Oct 04 2024 - 09:56:18 EST


On Fri, Oct 04, 2024 at 03:41:22PM +0200, Alexander Potapenko wrote:
> On Fri, Oct 4, 2024 at 2:57 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Fri, Oct 04, 2024 at 12:33:13PM +0000, Pimyn@xxxxxxxxxxxxxxxxxx wrote:
>
> Just curious, what's up with this @web.codeaurora.org address? It
> wasn't in the original patch, where did it come from? :)

You tell me, look at the original patch, it's in the email...

> > > Avoid kernel-usb-infoleak by initializing all memory written to device.
> > > The buffer length uses 32bit alignment which might cause some buffer
> > > data to be read without any initialization.
> > >
> > > Reported-by: syzbot+8f282cce71948071c335@xxxxxxxxxxxxxxxxxxxxxxxxx
> > > Closes: https://lore.kernel.org/all/0000000000006f6622061eb52dba@xxxxxxxxxx/T/
> > > Signed-off-by: Pimyn Girgis <bemenboshra2001@xxxxxxxxx> (Google)
> > > ---
> > > drivers/usb/class/usbtmc.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> >
> > The "From:" line of this commit is obviously not correct and does not
> > match this signed-off-by line.
>
> Sorry, does it mean the "(Google)" part should be present in the From:
> line as well?

A valid email address should be in the "From:" line.

> > Also, as you are from google, just use your google.com email address
> > please.
>
> Unfortunately Pimyn cannot send emails outside the @google.com domain.

Google has well-known facilities and abilities to handle this, please
use them and do not hide behind gmail accounts.

thanks,

greg k-h