Re: [net-next v3] idpf: Don't hard code napi_struct size

From: Alexander Lobakin
Date: Fri Oct 04 2024 - 10:23:21 EST


From: Joe Damato <jdamato@xxxxxxxxxx>
Date: Fri, 4 Oct 2024 10:54:07 +0000

> The sizeof(struct napi_struct) can change. Don't hardcode the size to
> 400 bytes and instead use "sizeof(struct napi_struct)".
>
> Suggested-by: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx>
> Signed-off-by: Joe Damato <jdamato@xxxxxxxxxx>

Acked-by: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx>

I'm sorry that I complicated things a bit with those assertions =\

> ---
> drivers/net/ethernet/intel/idpf/idpf_txrx.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.h b/drivers/net/ethernet/intel/idpf/idpf_txrx.h
> index f0537826f840..9c1fe84108ed 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.h
> +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.h
> @@ -438,7 +438,8 @@ struct idpf_q_vector {
> __cacheline_group_end_aligned(cold);
> };
> libeth_cacheline_set_assert(struct idpf_q_vector, 112,
> - 424 + 2 * sizeof(struct dim),
> + 24 + sizeof(struct napi_struct) +
> + 2 * sizeof(struct dim),
> 8 + sizeof(cpumask_var_t));
>
> struct idpf_rx_queue_stats {

Thanks,
Olek