Re: [PATCH v2 1/6] Add AutoFDO support for Clang build

From: Kees Cook
Date: Fri Oct 04 2024 - 14:15:37 EST


On Thu, Oct 03, 2024 at 05:41:43PM +0200, Peter Zijlstra wrote:
> On Wed, Oct 02, 2024 at 04:34:00PM -0700, Rong Xu wrote:
> > +Preparation
> > +===========
> > +
> > +Configure the kernel with:
> > +
> > + .. code-block:: make
> > +
> > + CONFIG_AUTOFDO_CLANG=y
> > +
> > +
> [...]
> > + With a configuration that with LLVM enabled, use the following command:
> > +
> > + .. code-block:: sh
> > +
> > + $ scripts/config -e AUTOFDO_CLANG
> [...]
>
> Can this be done without the endless ... code-block nonsense?

The tradition in kernel .rst is to do this with the trailing "::", e.g.:

+Configure the kernel with::
+
+ CONFIG_AUTOFDO_CLANG=y

This loses the language-specific highlighting when rendered. Perhaps the
"::" extension can be further extended?

+Configure the kernel with::(make)
+
+ CONFIG_AUTOFDO_CLANG=y

Then we could avoid the extra 2 lines but still gain the rendered language
highlights?

--
Kees Cook