[gustavoars:testing/wfamnae-next20241003 14/14] kernel/bpf/core.c:2505:22: warning: comparison of distinct pointer types ('struct bpf_prog_array *' and 'struct bpf_prog_array_hdr *')

From: kernel test robot
Date: Fri Oct 04 2024 - 14:28:06 EST


tree: https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git testing/wfamnae-next20241003
head: ec64acf2dce7577a42c01241e78b24afebc26e96
commit: ec64acf2dce7577a42c01241e78b24afebc26e96 [14/14] treewide_some: fix multiple -Wfamnae warnings that must be audited separately
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20241005/202410050215.8zVNACRw-lkp@xxxxxxxxx/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241005/202410050215.8zVNACRw-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410050215.8zVNACRw-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> kernel/bpf/core.c:2505:22: warning: comparison of distinct pointer types ('struct bpf_prog_array *' and 'struct bpf_prog_array_hdr *') [-Wcompare-distinct-pointer-types]
2505 | if (!progs || progs == &bpf_empty_prog_array.hdr)
| ~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.


vim +2505 kernel/bpf/core.c

8c7dcb84e3b744 Delyan Kratunov 2022-06-14 2502
8c7dcb84e3b744 Delyan Kratunov 2022-06-14 2503 void bpf_prog_array_free_sleepable(struct bpf_prog_array *progs)
8c7dcb84e3b744 Delyan Kratunov 2022-06-14 2504 {
8c7dcb84e3b744 Delyan Kratunov 2022-06-14 @2505 if (!progs || progs == &bpf_empty_prog_array.hdr)
8c7dcb84e3b744 Delyan Kratunov 2022-06-14 2506 return;
8c7dcb84e3b744 Delyan Kratunov 2022-06-14 2507 call_rcu_tasks_trace(&progs->rcu, __bpf_prog_array_free_sleepable_cb);
8c7dcb84e3b744 Delyan Kratunov 2022-06-14 2508 }
8c7dcb84e3b744 Delyan Kratunov 2022-06-14 2509

:::::: The code at line 2505 was first introduced by commit
:::::: 8c7dcb84e3b744b2b70baa7a44a9b1881c33a9c9 bpf: implement sleepable uprobes by chaining gps

:::::: TO: Delyan Kratunov <delyank@xxxxxx>
:::::: CC: Alexei Starovoitov <ast@xxxxxxxxxx>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki