Re: [PATCH] selftests: sched_ext: Add sched_ext as proper selftest target

[Shuah Khan]

On 10/4/24 11:46, Shuah Khan wrote:
> On 10/4/24 03:42, Björn Töpel wrote:
> > From: Björn Töpel <bjorn@xxxxxxxxxxxx>
> >
> > The sched_ext selftests is missing proper cross-compilation support, a
> > proper target entry, and out-of-tree build support.
> >
> > When building the kselftest suite, e.g.:
> >
> >    make ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- \
> >      SKIP_TARGETS="" O=/output/foo -C tools/testing/selftests install
> >
> > The expectation is that the sched_ext is included, cross-built, and
> > placed into /output/foo.
> >
> > Add CROSS_COMPILE, OUTPUT, and TARGETS support to the sched_ext
> > selftest.
> >
> > Signed-off-by: Björn Töpel <bjorn@xxxxxxxxxxxx>
> > ---
> >   tools/testing/selftests/Makefile           |  1 +
> >   tools/testing/selftests/sched_ext/Makefile | 59 +++++++++++++++-------
> >   2 files changed, 41 insertions(+), 19 deletions(-)
>
> Thank you for the find. It appears *sched* is also missing
> from the default TARGETS in selftests/Makefile
>
> This change looks good to me.
>
> Reviewed-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
>
> Tejun, Do let me know if you like me to take this through kselftest tree.

Please don't take this patch at the moment.

Adding Mark.

After catching up with my Inbox - this is a no for me. This test
depends on bpf and will fail in CIs that don't have the support.

We are discussing the issue here in this thread.

https://patchwork.kernel.org/project/linux-kselftest/patch/20241004095348.797020-1-bjorn@xxxxxxxxxx/

thanks,
-- Shuah