Re: [PATCH v1 2/2] selftests/rseq: Fix mm_cid test failure

From: Shuah Khan
Date: Fri Oct 04 2024 - 16:05:17 EST


On 10/3/24 18:44, Mathieu Desnoyers wrote:
Adapt the rseq.c/rseq.h code to follow GNU C library changes introduced by:

commit 2e456ccf0c34 ("Linux: Make __rseq_size useful for feature detection (bug 31965)")

Without this fix, rseq selftests for mm_cid fail:

./run_param_test.sh
Default parameters
Running test spinlock
Running compare-twice test spinlock
Running mm_cid test spinlock
Error: cpu id getter unavailable

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>
Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
CC: Boqun Feng <boqun.feng@xxxxxxxxx>
CC: "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx>
Cc: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
CC: Carlos O'Donell <carlos@xxxxxxxxxx>
CC: Florian Weimer <fweimer@xxxxxxxxxx>
---
tools/testing/selftests/rseq/rseq.c | 109 +++++++++++++++++++---------
tools/testing/selftests/rseq/rseq.h | 10 +--
2 files changed, 76 insertions(+), 43 deletions(-)


Looks good to me.

Acked-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>

Peter, Ingo - let me know if you plan to take this through
one of your trees. Otherwise I will pick it up.

thanks,
-- Shuah