Re: [PATCH 1/2] dt-bindings: arm64: bcmbca: Add Zyxel EX3510-B based on BCM4906

From: Krzysztof Kozlowski
Date: Sat Oct 05 2024 - 04:54:12 EST


On 04/10/2024 19:21, Sam Edwards wrote:
> On Thu, Oct 3, 2024 at 11:51 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>>
>> On 04/10/2024 08:49, Krzysztof Kozlowski wrote:
>>> On Thu, Oct 03, 2024 at 03:08:19PM -0700, Sam Edwards wrote:
>>>> This is a series (EX3510-B0 and EX3510-B1) of residential gateways based
>>>> on BCM4906, a stripped-down version of the BCM4908 SoC. Although Zyxel's
>>>> marketing materials call this a "series," the EX3510-B1 appears to be a
>>>> very minor revision of the EX3510-B0, with only changes that are
>>>> transparent to software. As far as Linux is concerned, this "series"
>>>> effectively represents a single model.
>>>>
>>>> Signed-off-by: Sam Edwards <CFSworks@xxxxxxxxx>
>
> Good day Krzysztof,
>
>>>
>>> Can you use the same email as for SoB?
>
> I have sent patches to the LKML from a work email before, but I just

That's not what I asked. You can send them from whatever, I asked that
commit identity should match SoB in exact way.


> double-checked that I am using my personal email for everything here:
>
> $ git show ec8e6d96a05f04 | grep -E 'dt-bindings|Author|Signed'
> Author: Sam Edwards <CFSworks@xxxxxxxxx>
> dt-bindings: arm64: bcmbca: Add Zyxel EX3510-B based on BCM4906
> Signed-off-by: Sam Edwards <CFSworks@xxxxxxxxx>
> $ grep -E '^From|^Signed'
> outgoing-ex3510b/0001-dt-bindings-arm64-bcmbca-Add-Zyxel-EX3510-B-based-on.patch
> From ec8e6d96a05f04df00d05dec00df80172d233d8c Mon Sep 17 00:00:00 2001
> From: Sam Edwards <CFSworks@xxxxxxxxx>
> Signed-off-by: Sam Edwards <CFSworks@xxxxxxxxx>

So apply the patch from the mailing list and you will see:

Author: Sam Edwards <cfsworks@xxxxxxxxx>
Signed-off-by: Sam Edwards <CFSworks@xxxxxxxxx>

Best regards,
Krzysztof