Re: [PATCH v14 2/3] i2c: aspeed: support AST2600 i2c new register mode driver
From: kernel test robot
Date: Sat Oct 05 2024 - 06:01:29 EST
Hi Ryan,
kernel test robot noticed the following build errors:
[auto build test ERROR on v6.11]
[cannot apply to andi-shyti/i2c/i2c-host v6.12-rc1 linus/master next-20241004]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Ryan-Chen/dt-bindings-i2c-aspeed-support-for-AST2600-i2cv2/20241002-150410
base: v6.11
patch link: https://lore.kernel.org/r/20241002070213.1165263-3-ryan_chen%40aspeedtech.com
patch subject: [PATCH v14 2/3] i2c: aspeed: support AST2600 i2c new register mode driver
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20241005/202410051759.bRIS387l-lkp@xxxxxxxxx/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241005/202410051759.bRIS387l-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410051759.bRIS387l-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
>> drivers/i2c/busses/i2c-ast2600.c:437:6: error: call to undeclared function 'get_unaligned_le16'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
437 | get_unaligned_le16(&msg->buf[i2c_bus->master_xfer_cnt + i]);
| ^
>> drivers/i2c/busses/i2c-ast2600.c:441:6: error: call to undeclared function 'get_unaligned_le24'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
441 | get_unaligned_le24(&msg->buf[i2c_bus->master_xfer_cnt + i]);
| ^
>> drivers/i2c/busses/i2c-ast2600.c:445:6: error: call to undeclared function 'get_unaligned_le32'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
445 | get_unaligned_le32(&msg->buf[i2c_bus->master_xfer_cnt + i]);
| ^
3 errors generated.
vim +/get_unaligned_le16 +437 drivers/i2c/busses/i2c-ast2600.c
405
406 static int ast2600_i2c_setup_buff_tx(u32 cmd, struct ast2600_i2c_bus *i2c_bus)
407 {
408 struct i2c_msg *msg = &i2c_bus->msgs[i2c_bus->msgs_index];
409 u32 wbuf_dword;
410 int xfer_len;
411 int i;
412
413 cmd |= AST2600_I2CM_PKT_EN;
414 xfer_len = msg->len - i2c_bus->master_xfer_cnt;
415 if (xfer_len > i2c_bus->buf_size)
416 xfer_len = i2c_bus->buf_size;
417 else if (i2c_bus->msgs_index + 1 == i2c_bus->msgs_count)
418 cmd |= AST2600_I2CM_STOP_CMD;
419
420 if (cmd & AST2600_I2CM_START_CMD)
421 cmd |= AST2600_I2CM_PKT_ADDR(msg->addr);
422
423 if (xfer_len) {
424 cmd |= AST2600_I2CM_TX_BUFF_EN | AST2600_I2CM_TX_CMD;
425 /*
426 * The controller's buffer register supports dword writes only.
427 * Therefore, write dwords to the buffer register in a 4-byte aligned,
428 * and write the remaining unaligned data at the end.
429 */
430 for (i = 0; i < xfer_len; i += 4) {
431 switch (min(xfer_len - i, 4) % 4) {
432 case 1:
433 wbuf_dword = msg->buf[i2c_bus->master_xfer_cnt + i];
434 break;
435 case 2:
436 wbuf_dword =
> 437 get_unaligned_le16(&msg->buf[i2c_bus->master_xfer_cnt + i]);
438 break;
439 case 3:
440 wbuf_dword =
> 441 get_unaligned_le24(&msg->buf[i2c_bus->master_xfer_cnt + i]);
442 break;
443 default:
444 wbuf_dword =
> 445 get_unaligned_le32(&msg->buf[i2c_bus->master_xfer_cnt + i]);
446 break;
447 }
448 writel(wbuf_dword, i2c_bus->buf_base + i);
449 }
450 writel(AST2600_I2CC_SET_TX_BUF_LEN(xfer_len),
451 i2c_bus->reg_base + AST2600_I2CC_BUFF_CTRL);
452 }
453
454 writel(cmd, i2c_bus->reg_base + AST2600_I2CM_CMD_STS);
455
456 return 0;
457 }
458
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki