Re: [PATCH 1/3] iio: light: vl6180: Add configurable inter-measurement period support

[Jonathan Cameron]

On Sat, 5 Oct 2024 22:26:09 +0530
Abhash jha <abhashkumarjha123@xxxxxxxxx> wrote:

> > Hi Abhash,
> >
> > Sampling frequency must be in Hz and reflect how often the channel
> > is sampled (not just the inter measurement period.  So this sounds wrong.
> > It is sometimes complex to compute but we have to stick to the documented
> > ABI.  
> Got it. I thought of skipping out the complex computation in the
> driver and assumed
> the user would give me pre-computed ms values.
> 
> Just one thing, Is it better to just use IIO_CHAN_INFO_SAMP_FREQ for
> "inter-measurement period"
> and get the input in HZ (converting HZ to ms in driver)
This one.   
> Or
> Define a custom sysfs attribute like `inter_measurement_period` to get
> ms values? for this driver.
Always best to avoid custom attributes where at all possible because
standard userspace has no way to know how to use them.

Jonathan

> 
> Thanks,
> Abhash