Re: [PATCH v2 5/7] dt-bindings: iio: adc: add ad485x

[Jonathan Cameron]

On Fri, 4 Oct 2024 17:07:54 +0300
Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx> wrote:

> Add devicetree bindings for ad485x family.
> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>
Hi Antoniu

Trivial stuff inline to add to David's review.

Jonathan

> ---
>  1 file changed, 96 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad485x.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad485x.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad485x.yaml
> new file mode 100644
> index 000000000000..899a65504f12
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad485x.yaml
> @@ -0,0 +1,96 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright 2024 Analog Devices Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/adi,ad485x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AD485X family
> +
> +maintainers:
> +  - Sergiu Cuciurean <sergiu.cuciurean@xxxxxxxxxx>
> +  - Dragos Bogdan <dragos.bogdan@xxxxxxxxxx>
> +  - Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>
> +
> +description: |
> +  Analog Devices AD485X family

Give us some more idea of what these are.  Brief paragraph or two is fine giving
some key characteristics of these ADCs.  Whilst we know they are ADCs from
the path, maybe good to mention that :)


> +
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/ad4858.pdf
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/ad4857.pdf
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/ad4856.pdf
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/ad4855.pdf
Numeric order probably better than the reverse.

> +
> +$ref: /schemas/spi/spi-peripheral-props.yaml#