Re: [PATCH v3 13/14] drm/mediatek: Support DRM plane alpha in OVL

From: Adam Thiede
Date: Sat Oct 05 2024 - 13:32:35 EST


On 10/5/24 05:02, Jason-JH Lin (林睿祥) wrote:
> --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> @@ -102,12 +102,9 @@ static inline bool is_10bit_rgb(u32 fmt)
> }
> > static const u32 mt8173_formats[] = {
> - DRM_FORMAT_XRGB8888,
> DRM_FORMAT_ARGB8888,
> - DRM_FORMAT_BGRX8888,
> DRM_FORMAT_BGRA8888,
> DRM_FORMAT_ABGR8888,
> - DRM_FORMAT_XBGR8888,
> DRM_FORMAT_RGB888,
> DRM_FORMAT_BGR888,
> DRM_FORMAT_RGB565,

This is what I get on MT6735:

[ 1.729467] mediatek-drm mediatek-drm.1.auto: [drm] bpp/depth
value of 32/24 not supported
[ 1.737777] mediatek-drm mediatek-drm.1.auto: [drm] No compatible format found
[ 1.745943] mediatek-drm mediatek-drm.1.auto: [drm] *ERROR* fbdev-dma: Failed to setup generic emulation (ret=-22)


Hi Adam, Yassine,

Please try the patches below and check if they can fix the downgrade
issue:
[1] Fix degradation problem of alpha blending series
-
https://patchwork.kernel.org/project/linux-mediatek/list/?series=893634
[2] drm/mediatek: Fix XRGB format breakage for blend_modes unsupported
SoCs
-
https://patchwork.kernel.org/project/linux-mediatek/patch/20241005095234.12925-1-jason-jh.lin@xxxxxxxxxxxx/

Regards,
Jason-JH.Lin

Jason,
I've built 6.12-rc1 with those patch series applied. (I am also not reverting the other commit.) This fixes the issue - I'm able to see the console now. Thank you! Hopefully these can go into 6.12?
- Adam Thiede