Re: [PATCH v3 03/10] dt-bindings: iio: adc: ad7606: Add iio backend bindings

From: Rob Herring
Date: Sat Oct 05 2024 - 14:50:37 EST


On Fri, Oct 04, 2024 at 09:48:37PM +0000, Guillaume Stols wrote:
> Add the required properties for iio-backend support, as well as an
> example and the conditions to mutually exclude interruption and
> conversion trigger with iio-backend.
> The iio-backend's function is to controls the communication, and thus the
> interruption pin won't be available anymore.
> As a consequence, the conversion pin must be controlled externally since
> we will miss information about when every single conversion cycle (i.e
> conversion + data transfer) ends, hence a PWM is introduced to trigger
> the conversions.
>
> Signed-off-by: Guillaume Stols <gstols@xxxxxxxxxxxx>
> ---
> .../devicetree/bindings/iio/adc/adi,ad7606.yaml | 64 +++++++++++++++++++++-
> 1 file changed, 62 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> index 47081c79a1cf..a389cfda824d 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> @@ -129,6 +129,29 @@ properties:
> assumed that the pins are hardwired to VDD.
> type: boolean
>
> + pwms:
> + description:
> + In case the conversion is triggered by a PWM instead of a GPIO plugged to
> + the CONVST pin, the PWM must be referenced.
> + The first is the PWM connected to CONVST or CONVST1 for the chips with 2

s/2/2nd/

Otherwise,

Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>