[PATCH net-next 02/14] net: ibm: emac: tah: use devm for mutex_init

From: Rosen Penev
Date: Sat Oct 05 2024 - 22:29:14 EST


It seems that since inception, this driver never called mutex_destroy in
_remove. Use devm to handle this automatically.

Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
---
drivers/net/ethernet/ibm/emac/tah.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ibm/emac/tah.c b/drivers/net/ethernet/ibm/emac/tah.c
index 03e0a4445569..61f70066acb0 100644
--- a/drivers/net/ethernet/ibm/emac/tah.c
+++ b/drivers/net/ethernet/ibm/emac/tah.c
@@ -90,13 +90,17 @@ static int tah_probe(struct platform_device *ofdev)
struct device_node *np = ofdev->dev.of_node;
struct tah_instance *dev;
struct resource regs;
+ int err;

dev = devm_kzalloc(&ofdev->dev, sizeof(struct tah_instance),
GFP_KERNEL);
if (!dev)
return -ENOMEM;

- mutex_init(&dev->lock);
+ err = devm_mutex_init(&ofdev->dev, &dev->lock);
+ if (err)
+ return err;
+
dev->ofdev = ofdev;

if (of_address_to_resource(np, 0, &regs)) {
--
2.46.2