Re: [PATCH 3/3] arm64: dts: qcom: sc7280: Add cpucp mbox node

From: Bjorn Andersson
Date: Sat Oct 05 2024 - 22:35:43 EST


On Tue, Sep 24, 2024 at 10:39:41AM GMT, Shivnandan Kumar wrote:
> Add the CPUCP mailbox node required for communication with CPUCP.

I'd like to see a description of why that's useful...

But perhaps more importantly, why are there no user(s) of this?

Regards,
Bjorn

>
> Signed-off-by: Shivnandan Kumar <quic_kshivnan@xxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 3d8410683402..4b9b26a75c62 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -4009,6 +4009,14 @@ gem_noc: interconnect@9100000 {
> qcom,bcm-voters = <&apps_bcm_voter>;
> };
>
> + cpucp_mbox: mailbox@17430000 {
> + compatible = "qcom,sc7280-cpucp-mbox";
> + reg = <0 0x18590000 0 0x2000>,
> + <0 0x17C00000 0 0x10>;
> + interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
> + #mbox-cells = <1>;
> + };
> +
> system-cache-controller@9200000 {
> compatible = "qcom,sc7280-llcc";
> reg = <0 0x09200000 0 0x58000>, <0 0x09280000 0 0x58000>,
> --
> 2.25.1
>